[libvirt] [PATCH 4/4] parallels: prevent domain define only if vcpupin is specified

Peter Krempa pkrempa at redhat.com
Wed Mar 11 08:10:10 UTC 2015


On Tue, Mar 10, 2015 at 23:12:22 +0300, Maxim Nestratov wrote:
> and their settings differ from common cpumask
> 
> Signed-off-by: Maxim Nestratov <mnestratov at parallels.com>
> ---
>  src/parallels/parallels_sdk.c |   14 ++++++++++++--
>  1 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
> index 4ec9161..fde908b 100644
> --- a/src/parallels/parallels_sdk.c
> +++ b/src/parallels/parallels_sdk.c
> @@ -1808,14 +1808,24 @@ prlsdkCheckUnsupportedParams(PRL_HANDLE sdkdom, virDomainDefPtr def)
>      if (def->cputune.shares ||
>          def->cputune.sharesSpecified ||
>          def->cputune.period ||
> -        def->cputune.quota ||
> -        def->cputune.nvcpupin) {
> +        def->cputune.quota) {
>  
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>                         _("cputune is not supported by parallels driver"));
>          return -1;
>      }
>  
> +    if (def->cputune.vcpupin) {
> +       for (i = 0; i < def->vcpus; i++) {

While this is still correct as the rest of the vcpupin array is filled
by the default cpu pinning mask, the rest of the cpus can be skipped.

ACK regardless.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150311/9c84d54b/attachment-0001.sig>


More information about the libvir-list mailing list