[libvirt] [PATCH 7/6] qemu: move virDomainLiveConfigHelperMethod right after BeginJob

Peter Krempa pkrempa at redhat.com
Tue Mar 24 16:13:07 UTC 2015


On Fri, Mar 20, 2015 at 15:58:56 +0100, Pavel Hrdina wrote:
> We should call virDomainLiveConfigHelperMethod ASAP because this
> function transfers VIR_DOMAIN_AFFECT_CURRENT to VIR_DOMAIN_AFFECT_LIVE
> or VIR_DOMAIN_AFFECT_CONFIG.  All other additional checks for those two
> flags should consider that the user give us VIR_DOMAIN_AFFECT_CURRENT.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

ACK, although this should be 0.5/6 or 1.5/6. Basically just push this
first.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150324/56c42fac/attachment-0001.sig>


More information about the libvir-list mailing list