[libvirt] crash in virDomainNumaGetMemorySize

[Peter Krempa]

On Fri, Sep 18, 2015 at 17:10:20 +0200, Olaf Hering wrote:
> With current master (56945e1), while toying around with a WS2008R2 Hyper-V host:

Hi, thanks for reporting this. I've (hopefully) fixed the issue with:


commit 403e86067d5cb3a6fd8583cb5b08121151bd4d9f
Author: Peter Krempa <pkrempa at redhat.com>
Date:   Thu Aug 13 16:39:28 2015 +0200

    conf: Pre-calculate initial memory size instead of always calculating it
    
    Add 'initial_memory' member to struct virDomainMemtune so that the
    memory size can be pre-calculated once instead of inferring it always
    again and again.
    
    Separating of the fields will also allow finer granularity of decisions
    in later patches where it will allow to keep the old initial memory
    value in cases where we are handling incomming migration from older
    versions that did not always update the size from NUMA as the code did
    previously.
    
    The change also requires modification of the qemu memory alignment
    function since at the point where we are modifying the size of NUMA
    nodes the total size needs to be recalculated too.
    
    The refactoring done in this patch also fixes a crash in the hyperv
    driver that did not properly initialize def->numa and thus
    virDomainNumaGetMemorySize(def->numa) crashed.
    
    In summary this patch should have no functional impact at this point.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151013/c71e7cd8/attachment-0001.sig>