[libvirt] [PATCH 07/10] qemu: domain: Remove memory device check from post parse callback

Peter Krempa pkrempa at redhat.com
Fri Oct 16 12:11:44 UTC 2015


We check that <maxMemory> is present when we have memory devices at the
time we start the VM or add the device, so we can remove it from the
post parse callback to be more tolerant to users.
---
 src/qemu/qemu_domain.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 1474a5b..a22e5ad 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1347,14 +1347,6 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
         }
     }

-    if (dev->type == VIR_DOMAIN_DEVICE_MEMORY &&
-        !virDomainDefHasMemoryHotplug(def)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("maxMemory has to be specified when using memory "
-                         "devices "));
-        goto cleanup;
-    }
-
     ret = 0;

  cleanup:
-- 
2.4.5




More information about the libvir-list mailing list