[libvirt] [PATCH 08/12] qemu-command: Move qemuDomain*Address* functions to qemu_domain.c
jferlan at redhat.com
Tue Feb 16 14:36:58 UTC 2016
On 02/16/2016 08:58 AM, Ján Tomko wrote:
> On Mon, Feb 15, 2016 at 02:37:22PM -0500, John Ferlan wrote:
>> Move the functions into qemu_domain.c - additionally move any supporting
>> static functions.
>> Make qemuDomainSupportsPCI non static.
>> Also, move and rename the following:
>> qemuSetSCSIControllerModel to qemuDomainSetSCSIControllerModel
>> qemuCollectPCIAddress to qemuDomainCollectPCIAddress
>> qemuValidateDevicePCISlotsPIIX3 to qemuDomainValidateDevicePCISlotsPIIX3
>> qemuAssignDevicePCISlots to qemuDomainAssignDevicePCISlots
> Most of these deal with domain addresses and qemu_domain.c is growing
> pretty large. I think they deserve a qemu_domain_addr.c module. (On the
> other hand, strictly sticking to the qemuDomainAddr prefix will make the
> function names too long)
So if this was a create a qemu_domain_addr.c module and move those
functions in there, would that work for you? Someone else can move
other virDomain*Address* functions afterwards... For some reason I have
a recollection of another thread on that a while back.
w/r/t the qemuDomain vs. qemuDomainAddr prefix-ing, I think
qemu_hotplug.c already uses qemuDomain prefixes, so keeping virDomain
(for now) should be OK.
Would you want to see the adjustment?
More information about the libvir-list