[libvirt] [PATCH] Dont set ABI update flag during migration cookie parsing for persistent copy

[Shivaprasad bhat]

Please drop this patch. I sent it too early. I think the existing migration
behavior with --persistent is expected.

Thanks,
Shiva



On Tue, Jan 26, 2016 at 1:31 PM, Shivaprasad G Bhat <
shivaprasadbhat at gmail.com> wrote:

> The migration would fail if the checks in virDomainDefPostParseMemory()
> fail
> after ABI update. The ABI update normally done during the guest start and
> not
> during define. If someone is using --persistent with the virsh
> migrate it should be treated equivalent to domain define and not start. The
> furture restart would/should anyway do the ABI updates and flag correct
> errors.
>
> Signed-off-by: Shivaprasad G Bhat <sbhat at linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_migration.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 51e7125..39e259a 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -1284,8 +1284,7 @@ qemuMigrationCookieXMLParse(qemuMigrationCookiePtr
> mig,
>          }
>          mig->persistent = virDomainDefParseNode(doc, nodes[0],
>                                                  caps, driver->xmlopt,
> -
> VIR_DOMAIN_DEF_PARSE_INACTIVE |
> -
> VIR_DOMAIN_DEF_PARSE_ABI_UPDATE);
> +
> VIR_DOMAIN_DEF_PARSE_INACTIVE);
>          if (!mig->persistent) {
>              /* virDomainDefParseNode already reported
>               * an error for us */
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160126/d23acd2a/attachment-0001.htm>