[libvirt] [PATCH 3/6] qemu: Add support for parsing iotune group setting

[Erik Skultety]

On Mon, Oct 31, 2016 at 05:22:59PM -0400, John Ferlan wrote:
> Add support to read/parse the iotune group setting for qemu.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  include/libvirt/libvirt-domain.h |  8 +++++
>  src/conf/domain_conf.c           |  1 +
>  src/conf/domain_conf.h           |  1 +
>  src/qemu/qemu_driver.c           | 50 ++++++++++++++++++++++++---
>  src/qemu/qemu_monitor.c          |  2 ++
>  src/qemu/qemu_monitor.h          |  1 +
>  src/qemu/qemu_monitor_json.c     | 21 ++++++++++--
>  src/qemu/qemu_monitor_json.h     |  1 +
>  tests/qemumonitorjsontest.c      | 74 +++++++++++++++++++++++++++++++---------
>  9 files changed, 134 insertions(+), 25 deletions(-)
> 

[...]

> @@ -17316,7 +17317,8 @@ qemuDomainSetBlockIoTuneDefaults(virDomainBlockIoTuneInfoPtr newinfo,
>                                   bool set_iops_max,
>                                   bool set_size_iops,
>                                   bool set_bytes_max_length,
> -                                 bool set_iops_max_length)
> +                                 bool set_iops_max_length,
> +                                 bool set_group_name)
>  {

Additionally to what Martin suggested in his review, I'd like to reiterate the
idea of converting the 8 booleans to OR'd flags.

Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161102/40efc9a5/attachment-0001.sig>