[libvirt] [PATCH 0/5] wireshark: Fix $(prefix) handling

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Wed Oct 26 15:55:31 UTC 2016


On 26.10.2016 15:27, Andrea Bolognani wrote:
> Well, almost :) There are still some cases that are not
> handled correctly, but at least this will unbreak 'make
> rpm' while I work on the rest.
> 
> Tested by running 'make rpm' successfully on Fedora 23,
> Fedora 24 and Fedora rawhide.
> 
> 
> Andrea Bolognani (5):
>   wireshark: Introduce $ws_modversion
>   wireshark: Hoist $ws_prefix declaration
>   wireshark: Strip prefix correctly
>   wireshark: Inject $(prefix) at the right time
>   wireshark: Rename plugindir to ws_plugindir
> 
>  m4/virt-wireshark.m4 | 29 ++++++++++++++++++-----------
>  tools/Makefile.am    |  2 +-
>  2 files changed, 19 insertions(+), 12 deletions(-)
> 

Thanks for the fixes. As it happens, I have tried to fix our local
builds in parallel, and thus have some minor suggestions, patch attached.

-- 

Mit freundlichen Grüßen/Kind Regards
   Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wireshark-minor-improvements-for-plugin-directory-de.patch
Type: text/x-patch
Size: 3456 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161026/f6e965df/attachment-0001.bin>


More information about the libvir-list mailing list