[libvirt] [PATCH v2] Add support for Veritas HyperScale (VxHS) block device protocol

[Peter Krempa]

On Sat, Jan 14, 2017 at 10:31:05 -0500, John Ferlan wrote:
> [...]
> 
> >> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
> >> new file mode 100644
> >> index 0000000..f6e3e37
> >> --- /dev/null
> >> +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args

[...]

> >> +-drive file=vxhs://192.168.0.1:9999/eb90327c-8302-4725-9e1b-4e85ed4dc251,\
> >> +format=raw,if=none,id=drive-virtio-disk0,cache=none \
> > 
> > Please use the modern syntax for disk specification, not the
> > legacy URI syntax  ie
> > 
> >   -drive  driver=vxhs,vdisk-id=eb90327c-8302-4725-4e85ed4dc251,\
> >           server.host=example.com,server.port=12345,format=raw,
> > 	  if=none,id=driver-virtio-disk0,cache=0
> > 
> 
> FWIW: qemuBuildDriveStr doesn't support that yet for any driver -
> although it probably should be updated... Timing wise whether that work
> could get done before this work is ready - I'm not sure. While I agree
> the code "should" use the new syntax - I do think we'd have to make
> adjustments to all drive strings. That would probably mean knowing
> whether the new syntax was "in place" before the current libvirt qemu
> minimum version...

That's not true. The new syntax is used for multi-host gluster disks
(qemuGetDriveSourceProps). Also we have QMP introspection code in place
which can detect whether given configuration option is supported by the
given qemu (virQEMUCapsQMPSchemaQueries[]).

Also we should not fully update the command line generator in cases
where it's not necessary as it would just make the code more complex
without any real benefit. The new protocols can use the new syntax
though.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170116/5d59a817/attachment-0001.sig>