[libvirt] [PATCH] CI: also run tests using updated distro(s)

Martin Kletzander mkletzan at redhat.com
Wed May 31 07:12:08 UTC 2017

On Tue, May 30, 2017 at 03:52:06PM -0300, Claudio André wrote:
>Em 29/05/2017 08:54, Martin Kletzander escreveu:
>> On Sun, May 28, 2017 at 11:07:41PM -0300, claudioandre.br at gmail.com
>> wrote:
>>> From: Claudio André <claudioandre.br at gmail.com>
>> 'modprobe -c' fails for some reason.
>Ahh! Well, it is possible to run modprobe inside Docker if I enable some
>options. I'll
>check it.
>> Is the user inside the container root?  I don't think so.  Some more
>> info output
>> could be nice, like 'uname -a', 'id', and so on.
>I did it.
>> One disadvantage for using the script is that it couples al output
>> together.  I know it's needed for running that inside the container, but
>> the installation and configuration parts take lot of output that I had
>> to scroll through.  Could _that_ be separated at least?
>You can fold/collapsed the output yourself. That said, I folded the
>autogen part, but I'll
>keep the make unfolded (the way Travis does). Please, let me know if you
>want anything else folded (e.g., hide everything but tests).

That's great.  I was just talking about the fact that I didn't see the
option to keep something folded by default.

>And, please:
>- access https://travis-ci.org/claudioandre/libvirt/jobs/237625211
>- and look at line 485 to see the folding in action

Yeah, this looks great.  I like when it's more compact, I just want to
save some people some time in the future.

>> Also in your config (not here), you have some differences, for example
>> compiler: ["gcc"] even though it doesn't take arrays.  It doesn't
>> matter, I know, it just confused me a bit :D
>This was Travis itself. I fixed it, please, confirm that using the link
>seen above.
>> Somehow the -qq didn't work, or you didn't have it in the script in the
>> build you sent the link to.  That's ione of the things hidden fromt he
>> Web UI.
>Without -qq is much worse. We can:
>1. collapse as seen above;
>2. redirect stdout to /dev/null (I mean, there is no important
>information here).
>I prefer (and use) #2.

either -qq collapsed or just put it to /dev/null.  I don't care which
one, if there is a problem with the installation it will be in stderr

>The silent_if_passes() has some drawbacks.

Sure, I didn't know you can collapse part of the output of one command
and that was the first idea that came to my mind.

So the link shows the output with the current patch?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170531/48a6e1f0/attachment-0001.sig>

More information about the libvir-list mailing list