[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] CI: also run tests using updated distro(s)



Em 29/05/2017 08:54, Martin Kletzander escreveu:
On Sun, May 28, 2017 at 11:07:41PM -0300, claudioandre br gmail com wrote:
From: Claudio André <claudioandre br gmail com>

'modprobe -c' fails for some reason.

Ahh! Well, it is possible to run modprobe inside Docker if I enable some options. I'll
check it.

Is the user inside the container root? I don't think so. Some more info output
could be nice, like 'uname -a', 'id', and so on.

I did it.

One disadvantage for using the script is that it couples al output
together.  I know it's needed for running that inside the container, but
the installation and configuration parts take lot of output that I had
to scroll through.  Could _that_ be separated at least?

You can fold/collapsed the output yourself. That said, I folded the autogen part, but I'll
keep the make unfolded (the way Travis does). Please, let me know if you
want anything else folded (e.g., hide everything but tests).

And, please:
- access https://travis-ci.org/claudioandre/libvirt/jobs/237625211
- and look at line 485 to see the folding in action

Also in your config (not here), you have some differences, for example
compiler: ["gcc"] even though it doesn't take arrays.  It doesn't
matter, I know, it just confused me a bit :D

This was Travis itself. I fixed it, please, confirm that using the link seen above.

Somehow the -qq didn't work, or you didn't have it in the script in the
build you sent the link to.  That's ione of the things hidden fromt he
Web UI.

Without -qq is much worse. We can:
1. collapse as seen above;
2. redirect stdout to /dev/null (I mean, there is no important information here).

I prefer (and use) #2.

The silent_if_passes() has some drawbacks.

Claudio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]