[libvirt] [PATCH] resctl: stub out functions with Linux-only APIs used

Daniel P. Berrangé berrange at redhat.com
Wed Jan 31 13:28:32 UTC 2018

On Mon, Jan 29, 2018 at 08:59:35AM +0100, Martin Kletzander wrote:
> On Thu, Jan 25, 2018 at 05:44:04PM +0000, Daniel P. Berrangé wrote:
> > The flock() function and d_type field in struct dirent are not portable
> > to the mingw platform.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> > 
> >  * Pushed as CI build fix
> > 
> Thanks for that.  I have not seen a failure on travis, but I missed the ones on
> ci.centos.org.  However I think all of the functionality is probably pointless
> on non-Linux, so I'll disable the whole resctrl for that in a series I'm
> preparing.  Thanks for this.

Yes, I thought about figuring out a way to compile out the entire file,
but I wanted to avoid adding lots of #ifdefs in either the header file,
or the QEMU source. So I decided it was better to do the minimal fix of
just stubbing the virresctrl.c file pieces that broke. 

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

More information about the libvir-list mailing list