[libvirt] [PATCH] resctl: stub out functions with Linux-only APIs used

Martin Kletzander mkletzan at redhat.com
Wed Jan 31 13:32:49 UTC 2018

On Wed, Jan 31, 2018 at 01:28:32PM +0000, Daniel P. Berrangé wrote:
>On Mon, Jan 29, 2018 at 08:59:35AM +0100, Martin Kletzander wrote:
>> On Thu, Jan 25, 2018 at 05:44:04PM +0000, Daniel P. Berrangé wrote:
>> > The flock() function and d_type field in struct dirent are not portable
>> > to the mingw platform.
>> >
>> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>> > ---
>> >
>> >  * Pushed as CI build fix
>> >
>> Thanks for that.  I have not seen a failure on travis, but I missed the ones on
>> ci.centos.org.  However I think all of the functionality is probably pointless
>> on non-Linux, so I'll disable the whole resctrl for that in a series I'm
>> preparing.  Thanks for this.
>Yes, I thought about figuring out a way to compile out the entire file,
>but I wanted to avoid adding lots of #ifdefs in either the header file,
>or the QEMU source. So I decided it was better to do the minimal fix of
>just stubbing the virresctrl.c file pieces that broke.

No problem, I have a cleanup ready, I'll send it later on.  Thanks for the fix,

>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180131/d1755cda/attachment-0001.sig>

More information about the libvir-list mailing list