[libvirt] [PATCH v2 2/7] qemu: Add support for virtio-gpu-ccw video device on S390

[Farhan Ali]

On 03/22/2018 03:18 PM, Ján Tomko wrote:
> On Mon, Mar 19, 2018 at 02:35:30PM -0400, Farhan Ali wrote:
>> QEMU on S390 (since v2.11) can support the virtio-gpu-ccw device,
>> which can be used as a video device.
>>
>> Signed-off-by: Farhan Ali <alifm at linux.vnet.ibm.com>
>> ---
>> docs/formatdomain.html.in      |  3 +++
>> src/qemu/qemu_command.c        | 13 +++++++++++--
>> src/qemu/qemu_domain.c         |  2 +-
>> src/qemu/qemu_domain_address.c | 12 ++++++++++--
>> src/qemu/qemu_process.c        |  5 ++++-
>> 5 files changed, 29 insertions(+), 6 deletions(-)
>>
> 
>> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>> index 7022f7c..4aaf617 100644
>> --- a/src/qemu/qemu_domain.c
>> +++ b/src/qemu/qemu_domain.c
>> @@ -5425,7 +5425,7 @@ 
>> qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
>>         if (dev->data.video->type == VIR_DOMAIN_VIDEO_TYPE_DEFAULT) {
>>             if (ARCH_IS_PPC64(def->os.arch))
>>                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_VGA;
>> -            else if (qemuDomainIsVirt(def))
>> +            else if (qemuDomainIsVirt(def) || 
>> ARCH_IS_S390(def->os.arch))
>>                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_VIRTIO;
>>             else
>>                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_CIRRUS;
> 
> This hunk which does not 'add support' but 'changes the default' belongs
> in a separate patch IMO.
> 
> 

Hi Jan,

Well I thought it would have been better to keep all the video related 
changes in one patch. But if the the preference is to move this hunk out 
then I will move it into a separate patch.



> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>