[libvirt] [PATCH 17/41] remote: refactor how list of systemd unit files is built

[Daniel P. Berrangé]

On Fri, Jul 26, 2019 at 08:01:52PM +0200, Andrea Bolognani wrote:
> On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote:
> > The make logic assumes that the SYSTEMD_UNIT_FILES var can be built from
> > SYSTEMD_UNIT_FILES_IN by simply dropping the directory prefix and the
> > .in suffix.
> > 
> > This won't work in future when a single .in unit file can be used to
> > generate multiple different units.
> 
> IIUC this is mostly for sockets, correct? As in, with the entire
> series applied we'll have eg.
> 
>   SYSTEMD_UNIT_FILES += \
>     virtqemud.service \
>     virtqemud.socket \
>     virtqemud-ro.socket \
>     virtqemud-admin.socket \
>     $(NULL)
>   SYSTEMD_UNIT_FILES_IN += \
>     qemu/virtqemud.service.in \
>     $(NULL)
> 
> where virtqemud*.socket are not generated, as the current code
> would expect, from virtqemud*.socket.in, but rather from
> libvirtd*.socket.in - hence the need for this patch.

Yes

> Again IIUC there's nothing really stopping us from generating
> virtqemud*.service from libvirtd*.service.in, or at least from
> a common virtd*.service.in, since eg. virtqemud.service.in and
> virtlxcd.service.in are basically identical - it's just that you
> haven't unified the generation rules yet.

I'm was not anticipating sharing the service.in file, as many of
the parameters will be driver specific.

> Assuming I've understood the intent correctly, then the changes
> themselves look good, so
> 
>   Reviewed-by: Andrea Bolognani <abologna at redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|