[libvirt] [PATCH] run: Don't export unnecessary paths

Andrea Bolognani abologna at redhat.com
Thu Mar 14 09:19:17 UTC 2019


We're using virFileFindResourceFull() to locate resources
nowadays, which makes exporting these information in the
environment unnecessary: see

  virDriverLoadModule() for LIBVIRT_DRIVER_DIR
  virLockManagerPluginNew() for LIBVIRT_LOCK_MANAGER_PLUGIN_DIR
  virLockManagerLockDaemonConnectionNew() for VIRTLOCKD_PATH
  doRemoteOpen() for LIBVIRTD_PATH

As further proof that we don't need to expose the information
this way anymore, we're not even exporting VIRTLOGD_PATH, which
would be necessary if virLogManagerConnect() didn't already
take care of that for us.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 run.in | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/run.in b/run.in
index 06ad54b62b..9a1c6ea11a 100644
--- a/run.in
+++ b/run.in
@@ -60,11 +60,6 @@ else
 fi
 export PKG_CONFIG_PATH
 
-export LIBVIRT_DRIVER_DIR="$b/src/.libs"
-export LIBVIRT_LOCK_MANAGER_PLUGIN_DIR="$b/src/.libs"
-export VIRTLOCKD_PATH="$b/src"
-export LIBVIRTD_PATH="$b/src"
-
 # This is a cheap way to find some use-after-free and uninitialized
 # read problems when using glibc.
 random_val="$(awk 'BEGIN{srand(); print 1+int(255*rand())}' < /dev/null)"
-- 
2.20.1




More information about the libvir-list mailing list