[libvirt] [PATCH] src: don't statically link code that's already in libvirt.so

Ján Tomko jtomko at redhat.com
Thu May 16 12:56:21 UTC 2019


On Thu, May 16, 2019 at 12:09:57PM +0100, Daniel P. Berrangé wrote:
>virtlockd and virtlogd statically link to libvirt-net-rpc-server.la
>libvirt-net-rpc.la and libvirt_util.la. libvirt-iohelper statically

libvirt_iohelper

>links to libvirt_util.la. All this code is all already built into
>the main libvirt.so, so we should dynamically link all these pieces.
>
>This reduces the size of the libvirt-daemon RPM from 5.4 MB down to
>1.2 MB which is useful for container installs seeking minimal disk
>footprint.
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> src/Makefile.am             | 2 +-
> src/libvirt_remote.syms     | 1 +
> src/locking/Makefile.inc.am | 4 +---
> src/logging/Makefile.inc.am | 4 +---
> 4 files changed, 4 insertions(+), 7 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

libvirt_parthelper and libvirt_leaseshelper could benefit from the same
change.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190516/057a315f/attachment-0001.sig>


More information about the libvir-list mailing list