[libvirt] [PATCH] src: don't statically link code that's already in libvirt.so

[Daniel P. Berrangé]

On Thu, May 16, 2019 at 02:56:21PM +0200, Ján Tomko wrote:
> On Thu, May 16, 2019 at 12:09:57PM +0100, Daniel P. Berrangé wrote:
> > virtlockd and virtlogd statically link to libvirt-net-rpc-server.la
> > libvirt-net-rpc.la and libvirt_util.la. libvirt-iohelper statically
> 
> libvirt_iohelper
> 
> > links to libvirt_util.la. All this code is all already built into
> > the main libvirt.so, so we should dynamically link all these pieces.
> > 
> > This reduces the size of the libvirt-daemon RPM from 5.4 MB down to
> > 1.2 MB which is useful for container installs seeking minimal disk
> > footprint.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> > src/Makefile.am             | 2 +-
> > src/libvirt_remote.syms     | 1 +
> > src/locking/Makefile.inc.am | 4 +---
> > src/logging/Makefile.inc.am | 4 +---
> > 4 files changed, 4 insertions(+), 7 deletions(-)
> > 
> 
> Reviewed-by: Ján Tomko <jtomko at redhat.com>
> 
> libvirt_parthelper and libvirt_leaseshelper could benefit from the same
> change.

Ah good point, I forgot about those as they were in differnet RPMs

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|