[libvirt-python PATCH 1/3] test: workaround missing VIR_TYPED_PARAM enums in API definition

[Andrea Bolognani]

On Wed, 2020-04-29 at 14:36 +0100, Daniel P. Berrangé wrote:
> On Ubuntu 1804 with libvirt 4.0.0 libvirt-python build fails

s/1804/18.04/

> +++ b/sanitytest.py
> @@ -73,7 +73,11 @@ for n in second_pass:
> -    if type(val) != int:
> +    # Version 4.0.0 was broken as missing VIR_TYPED_PARAM enums
> +    # constants. This is harmless from POV of validating API
> +    # coverage so ignore this error.
> +    if (type(val) != int and
> +        not val.startswith("VIR_TYPED_PARAM_")):

Should this comment also contain a reference to Ubuntu 18.04? Or is
the issue present in any build of libvirt 4.0.0?


Unfortunately I don't feel qualified to review this patch. I suggest
that you post it on its own and get someone with libvirt-python
knowledge to review it.

-- 
Andrea Bolognani / Red Hat / Virtualization