[libvirt PATCH] src: conditionalize / remove use of sys/ioctl.h

Pavel Hrdina phrdina at redhat.com
Fri Jan 17 13:05:45 UTC 2020


On Fri, Jan 17, 2020 at 12:19:45PM +0000, Daniel P. Berrangé wrote:
> Remove many imports of sys/ioctl.h which are redundant,
> and conditionalize remaining usage that needs to compile
> on Windows platforms.
> 
> The previous change to remove the "nonblocking" gnulib
> module indirectly caused the loss of the "ioctl" gnulib
> module that we did not explicitly list in bootstrap.conf
> despite relying on.
> 
> Rather than re-introduce the "ioctl" module this patch
> makes it redundant.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
> 
> 
>  src/util/virhostcpu.c      | 4 +++-
>  src/util/virhostdev.c      | 1 -
>  src/util/virhostmem.c      | 1 -
>  src/util/virnetdev.c       | 4 +++-
>  src/util/virnetdevbridge.c | 4 +++-
>  src/util/virnetdevip.c     | 4 +++-
>  src/util/virnetdevtap.c    | 4 +++-
>  src/util/virperf.c         | 4 +++-
>  src/util/virvsock.c        | 4 +++-
>  9 files changed, 21 insertions(+), 9 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200117/bb33580d/attachment-0001.sig>


More information about the libvir-list mailing list