[PATCH 16/28] domain_conf: make virDomainDefFormatBlkiotune() void

Matt Coleman mcoleman at datto.com
Fri Nov 6 03:32:52 UTC 2020


This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt at datto.com>
---
 src/conf/domain_conf.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index edfaf7c8af..6c7b386551 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -29498,7 +29498,7 @@ virDomainVsockDefFormat(virBufferPtr buf,
 }
 
 
-static int
+static void
 virDomainDefFormatBlkiotune(virBufferPtr buf,
                             virDomainDefPtr def)
 {
@@ -29539,8 +29539,6 @@ virDomainDefFormatBlkiotune(virBufferPtr buf,
     }
 
     virXMLFormatElement(buf, "blkiotune", NULL, &childrenBuf);
-
-    return 0;
 }
 
 
@@ -29986,8 +29984,7 @@ virDomainDefFormatInternalSetRootName(virDomainDefPtr def,
     virBufferAsprintf(buf, "<currentMemory unit='KiB'>%llu</currentMemory>\n",
                       def->mem.cur_balloon);
 
-    if (virDomainDefFormatBlkiotune(buf, def) < 0)
-        return -1;
+    virDomainDefFormatBlkiotune(buf, def);
 
     virDomainMemtuneFormat(buf, &def->mem);
     virDomainMemorybackingFormat(buf, &def->mem);
-- 
2.27.0





More information about the libvir-list mailing list