[PATCH 8/8] tools: virsh: Reset error when keepalive registration fails

Ján Tomko jtomko at redhat.com
Thu Nov 12 15:17:22 UTC 2020


On a Thursday in 2020, Peter Krempa wrote:
>We try to enable keepalive oportunistically. If it's not supported by

*opportunistically

>the connection driver and it was not explicitly requested we keep the
>error object set and can report it in some cases accidentally:

I was going to complain about the trailing ':' when I realized 'git am'
dropped everything below. Consider indenting it or using a different
separator.

Jano
>
>--- stdout ---
>TEST: /home/pipo/libvirt/tests/virsh-self-test
>      !                                        1   FAILED
>--- stderr ---
>error: parameter 'target' of command 'attach-disk' must be listed before optional parameters
>error: this function is not supported by the connection driver: virConnectSetKeepAlive
>-------
>
>Clear the stored libvirt error.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> tools/virsh.c | 1 +
> 1 file changed, 1 insertion(+)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201112/e41b14f2/attachment-0001.sig>


More information about the libvir-list mailing list