[PATCH v2 4/7] hyperv: implement domainShutdown and domainShutdownFlags

Pino Toscano ptoscano at redhat.com
Tue Oct 13 07:55:14 UTC 2020

On Tuesday, 13 October 2020 07:14:01 CEST Matt Coleman wrote:
> +    hypervAddSimpleParam(params, "Force", "False");
> +    hypervAddSimpleParam(params, "Reason", _("Planned shutdown via libvirt"));

Is this message logged in the Hyper-V logs? If so, then I'd not
translate it: imagine an user running libvirt on an e.g. a French
locale, sending this query to an Hyper-V on e.g. German. While English
is not that different in this situation (still potentially not the
Hyper-V language), at least IMHO it gives something understandable.

Of course, in case the message is changed to an untranslated text,
then please leave a comment there, so noone accidentally makes it

Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201013/d543ab6a/attachment-0001.sig>

More information about the libvir-list mailing list