[PATCH 3/5] meson: Drop checks for some functions and header files

Ján Tomko jtomko at redhat.com
Wed Sep 2 09:56:13 UTC 2020

On a Tuesday in 2020, Michal Privoznik wrote:
>In meson.build, we check for presence of unshare() function
>explicitly (even though there is the function usability check a
>few hundred lines below), but never have any code depending on
>HAVE_UNSHARE. The same applies to stdarg.h and sys/sysctl.h
>header files - either we simply include them or guard their
>include using different conditionals.
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> meson.build | 3 ---
> 1 file changed, 3 deletions(-)
>diff --git a/meson.build b/meson.build
>index e193166a9b..cdf33436f3 100644
>--- a/meson.build
>+++ b/meson.build
>@@ -672,7 +672,6 @@ functions = [
>   'stat64',
>   'symlink',
>   'sysctlbyname',
>-  'unshare',
> ]
> foreach function : functions
>@@ -696,11 +695,9 @@ headers = [
>   'net/if.h',
>   'pty.h',
>   'pwd.h',
>-  'stdarg.h',

Actually, checking for stdarg.h is necessary on macOS where
we need to have HAVE_STDARG_H defined for readline to use the
correct prototype for rl_message.

See commit 9ea3424a178 for more context.

Also, if you want the CI pipeline on your fork to run FreeBSD
and macOS, you need to register the Cirrus CI app on your GitHub
clone, see:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200902/04f4b89a/attachment-0001.sig>

More information about the libvir-list mailing list