[libvirt PATCH] meson: add -Wformat explicitly

[Ján Tomko]

On a Tuesday in 2020, Pavel Hrdina wrote:
>If someone runs `meson setup --buildtype plain` meson ignores
>warning_level=2 that is in our meson.build file. The implication is
>that Meson will not automatically add -Wall which enables -Wformat.
>
>This breaks building libvirt from git with the buildtype set to plain.
>
>There is an issue reported [1] to not ignore warning_level silently
>and the change to ignore it was done by upstream commit [2].
>
>[1] <https://github.com/mesonbuild/meson/issues/7399>
>[2] <https://github.com/mesonbuild/meson/commit/8ee1c9a07a3a35e3ed262fbc358fd86c257a966e>
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> meson.build | 1 +
> 1 file changed, 1 insertion(+)
>

NACK, this is missing all the other -Wall flags.

Jano

>diff --git a/meson.build b/meson.build
>index e193166a9b..4e99b5ba39 100644
>--- a/meson.build
>+++ b/meson.build
>@@ -257,6 +257,7 @@ cc_flags += [
>   '-Wempty-body',
>   '-Wendif-labels',
>   '-Wexpansion-to-defined',
>+  '-Wformat',
>   '-Wformat-contains-nul',
>   '-Wformat-extra-args',
>   '-Wformat-nonliteral',
>-- 
>2.26.2
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200901/d955676f/attachment-0001.sig>