[libvirt PATCH v2 4/4] ci: Makefile: Expose the CI_USER_LOGIN variable for users to use

[Erik Skultety]

On Fri, Feb 12, 2021 at 04:04:04PM +0100, Andrea Bolognani wrote:
> On Fri, 2021-02-12 at 15:19 +0100, Erik Skultety wrote:
> > @@ -239,6 +241,7 @@ ci-help:
> >  	@echo "    CI_CLEAN=0          - do not delete '$(CI_SCRATCHDIR)' after completion"
> >  	@echo "    CI_REUSE=1          - re-use existing '$(CI_SCRATCHDIR)' content"
> >  	@echo "    CI_ENGINE=auto      - container engine to use (podman, docker)"
> > +	@echo "    CI_USER_LOGIN=$$USER      - which user should run in the container"
> 
> Alignment is completely broken here. But I just realized that $USER
> will get expanded here, so we have basically no way of keeping that
> consistent...

I didn't want to point it out earlier, since to me it's not a deal breaker :).

> 
> Basically, your original version of the help message was better,
> please go back to that one :)

Sure, will do, thanks for the review.

Erik

> 
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
>