[libvirt PATCH v2 09/13] util: move virStorageFileProbe code into storage_file

[Pavel Hrdina]

On Fri, Jan 22, 2021 at 09:57:03AM +0100, Peter Krempa wrote:
> On Thu, Jan 21, 2021 at 20:34:23 +0100, Pavel Hrdina wrote:
> > Same as virStorageFileBackend, it doesn't belong into util directory.
> 
> Arguably, after you remove the file access, it kinda becomes just an
> utility function.
> 
> On the other hand, it's use is strictly limited to the storage source
> code, so it makes sense to stop linking it with the general util module.
> 
> > 
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> >  po/POTFILES.in                                         |  2 +-
> >  src/libvirt_private.syms                               | 10 +++++-----
> >  src/qemu/qemu_driver.c                                 |  2 +-
> >  src/storage/storage_backend_gluster.c                  |  2 +-
> >  src/storage/storage_util.c                             |  2 +-
> >  src/storage_file/meson.build                           |  1 +
> >  .../storage_file_probe.c}                              |  6 +++---
> >  .../storage_file_probe.h}                              |  2 +-
> >  src/storage_file/storage_source.c                      |  2 +-
> >  src/util/meson.build                                   |  1 -
> >  10 files changed, 15 insertions(+), 15 deletions(-)
> >  rename src/{util/virstoragefileprobe.c => storage_file/storage_file_probe.c} (99%)
> >  rename src/{util/virstoragefileprobe.h => storage_file/storage_file_probe.h} (95%)
> > 
> > diff --git a/po/POTFILES.in b/po/POTFILES.in
> > index 4da22ede8f..eeff3f9f2f 100644
> > --- a/po/POTFILES.in
> > +++ b/po/POTFILES.in
> > @@ -226,6 +226,7 @@
> >  @SRCDIR at src/storage_file/storage_file_backend.c
> >  @SRCDIR at src/storage_file/storage_file_fs.c
> >  @SRCDIR at src/storage_file/storage_file_gluster.c
> > + at SRCDIR@src/storage_file/storage_file_probe.c
> 
> Hmm, I think we should add a prefix for the _fs and _gluster backend
> drivers so that it doesn't get confused with the probing code.

Good point. How about storage_file_backend_fs ?

> Also same comment as previous patch regarding naming.
> 
> Reviewed-by: Peter Krempa <pkrempa at redhat.com>
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210122/cb14d21c/attachment-0001.sig>