[PATCH 0/1] vircgroup: Fix nested cgroup on cleanup

Eric Farman farman at linux.ibm.com
Fri Mar 26 16:25:02 UTC 2021


Hi Pavel, et al,

Running Fedora 33 KVM/QEMU on s390x, I recently noticed a couple
of oddities when shutting down my guests, which I bisected between
7.0.0 and 7.1.0 to your commit:

  commit 184245f53b94fc84f727eb6e8a2aa52df02d69c0
  Author: Pavel Hrdina <phrdina at redhat.com>
  Date:   Tue Feb 9 12:33:53 2021 +0100

      vircgroup: introduce nested cgroup to properly work with systemd

The attached patch is based on some of the tweaks you did to use the
parent/nested pointers in a cgroup, rather than a cgroup itself.
It fixes both problems I'm encountering, but as this code is quite
unfamiliar to me, I might well be way off track and would appreciate
your feedback in the matter.

Apologies for hitting this on the same day as freeze; I had not
noticed the messages previously, and started digging yesterday when
I noted the number of file descriptors left open by libvirt.

Thanks,
Eric

Eric Farman (1):
  vircgroup: Cleanup nested cgroups

 src/util/vircgroup.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.25.1




More information about the libvir-list mailing list