[RFC REPOST 4/7] src: introduce virDomainSetFibreChannelAppid API

[Michal Prívozník]

On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  include/libvirt/libvirt-domain.h |  4 +++
>  src/driver-hypervisor.h          |  6 +++++
>  src/libvirt-domain.c             | 44 ++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms          |  1 +
>  4 files changed, 55 insertions(+)
> 


> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index a8a386e839..f3e6854a39 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -13229,3 +13229,47 @@ virDomainStartDirtyRateCalc(virDomainPtr domain,
>      virDispatchError(conn);
>      return -1;
>  }
> +
> +
> +/**
> + * virDomainSetFibreChannelAppid:
> + * @domain: a domain object
> + * @appid: user provided appid string
> + * @flags: extra flags

I like the following more:

 * @flags: extra flags; not used yet, so callers should always pass 0

> + *
> + * Set the Fibre Channel APPID. Accepts only printable characters
> + * and maximal length is 128 characters. To remove the APPID use
> + * NULL as @appid value.
> + *
> + * Returns 0 in case of success, -1 otherwise.
> + */

Michal