[libvirt PATCH 07/21] meson: remove obsolete check for ETHTOOL_GGRO

Daniel P. Berrangé berrange at redhat.com
Thu Dec 8 14:35:11 UTC 2022


The ETHTOOL_GGRO constant was introduced to Linux in

  commit b240a0e5644eb817c4a397098a40e1ad42a615bc
  Author: Herbert Xu <herbert at gondor.apana.org.au>
  Date:   Mon Dec 15 23:44:31 2008 -0800

    ethtool: Add GGRO and SGRO ops

This is old enough that all our supported platforms can be assumed
to have this feature.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 meson.build          | 1 -
 src/util/virnetdev.c | 2 --
 2 files changed, 3 deletions(-)

diff --git a/meson.build b/meson.build
index 69d79963f7..be5d356b88 100644
--- a/meson.build
+++ b/meson.build
@@ -654,7 +654,6 @@ symbols = [
   [ 'linux/ethtool.h', 'ETH_FLAG_NTUPLE' ],
   [ 'linux/ethtool.h', 'ETH_FLAG_RXHASH' ],
   [ 'linux/ethtool.h', 'ETH_FLAG_LRO' ],
-  [ 'linux/ethtool.h', 'ETHTOOL_GGRO' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GFLAGS' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GFEATURES' ],
   [ 'linux/ethtool.h', 'ETHTOOL_SCOALESCE' ],
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 3fdf71e41e..bf7393b476 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -3084,9 +3084,7 @@ virNetDevGetEthtoolFeatures(const char *ifname,
         {ETHTOOL_GSG, VIR_NET_DEV_FEAT_GSG},
         {ETHTOOL_GTSO, VIR_NET_DEV_FEAT_GTSO},
         {ETHTOOL_GGSO, VIR_NET_DEV_FEAT_GGSO},
-# if WITH_DECL_ETHTOOL_GGRO
         {ETHTOOL_GGRO, VIR_NET_DEV_FEAT_GGRO},
-# endif
     };
 
 # if WITH_DECL_ETHTOOL_GFLAGS
-- 
2.38.1



More information about the libvir-list mailing list