[PATCH] remote: conf: Mention that 'virtproxyd' doesn't require the '--listen' flag

[Pavel Hrdina]

On Tue, Jul 12, 2022 at 12:48:30PM +0200, Peter Krempa wrote:
> 'virtproxyd' doesn't have the '--listen' parameter and it's enough just
> to enable the corresponding option in the config.
> 
> The config file is generic for all the daemons and we just omit/adjust
> some sections. Adding a separate mechanism to omit the note about the
> '--listen' parameter would be overkill so mention explicitly that it's
> required only for libvirtd and not virtproxyd.
> 
> The section is omitted for other daemons.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2094641
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/remote/libvirtd.conf.in | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/src/remote/libvirtd.conf.in b/src/remote/libvirtd.conf.in
> index defe6b83d0..929d3922e9 100644
> --- a/src/remote/libvirtd.conf.in
> +++ b/src/remote/libvirtd.conf.in
> @@ -8,8 +8,10 @@
>  #
> 
>  # Flag listening for secure TLS connections on the public TCP/IP port.
> -# NB, must pass the --listen flag to the @DAEMON_NAME@ process for this to
> -# have any effect.
> +#
> +# To enable listening sockets with the 'libvirtd' daemon it's also required  to

s/required  to/required to/

> +# pass the --listen flag on the commandline of the daemon.
> +# This is not needed with 'virtproxyd'.
>  #
>  # This setting is not required or honoured if using systemd socket
>  # activation.
> @@ -21,8 +23,10 @@
>  #listen_tls = 0
> 
>  # Listen for unencrypted TCP connections on the public TCP/IP port.
> -# NB, must pass the --listen flag to the @DAEMON_NAME@ process for this to
> -# have any effect.
> +#
> +# To enable listening sockets with the 'libvirtd' daemon it's also required  to

Same here, extra space.

> +# pass the --listen flag on the commandline of the daemon.
> +# This is not needed with 'virtproxyd'.
>  #
>  # This setting is not required or honoured if using systemd socket
>  # activation.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220712/1591bb20/attachment.sig>