[libvirt PATCH 20/20] qemu_snapshot: allow snapshot revert for external snapshots

Pavel Hrdina phrdina at redhat.com
Mon Mar 13 15:42:21 UTC 2023


Now that the support to revert external snapshots is implemented we can
drop this check.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/qemu/qemu_snapshot.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index c6c7b077dd..ec5b2e68d6 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1864,12 +1864,6 @@ qemuSnapshotRevertValidate(virDomainObj *vm,
         return -1;
     }
 
-    if (virDomainSnapshotIsExternal(snap)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("revert to external snapshot not supported yet"));
-        return -1;
-    }
-
     if (!snap->def->dom) {
         virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY,
                        _("snapshot '%s' lacks domain '%s' rollback info"),
-- 
2.39.2



More information about the libvir-list mailing list