[Libvirt-cim] [PATCH] Add cu_compare_ref()
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Fri Nov 2 23:38:01 UTC 2007
Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1194042578 25200
> # Node ID 0df048ad2e99c8eda6c843f148168a9fa0161399
> # Parent 05b01d03f0b801afe266d8d012bc464be6a2d165
> Add cu_compare_ref()
>
> This provides a generic way to easily compare a given ref against an instance,
> which should be useful in GetInstance functions for making sure the returned
> instance matches what was asked.
>
> +const struct cu_property *cu_compare_ref(const CMPIObjectPath *ref,
> + const CMPIInstance *inst,
> + const struct cu_property *props)
>
>
This looks good. Only minor issue is that you don't return the status,
but I the other cu_<> functions behave the same way. +1
--
Kaitlin Rupert
IBM Linux Technology Center
karupert at us.ibm.com
More information about the Libvirt-cim
mailing list