[Libvirt-cim] [PATCH] Add cu_compare_ref()

Dan Smith danms at us.ibm.com
Fri Nov 2 23:43:06 UTC 2007


KR> This looks good.  Only minor issue is that you don't return the
KR> status, but I the other cu_<> functions behave the same way.  +1

I don't return a CMPIStatus, but I do return a pointer to the caller's
cu_property struct that didn't pass the check, which they can use to
set a CMPIStatus if they wish (see my subsequent patches to
libvirt-cim).  I did it this way to avoid having to pass around a
CMPIBroker, and so that the caller has more control over the status
value.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071102/400df283/attachment.sig>


More information about the Libvirt-cim mailing list