[Libvirt-cim] [PATCH] Enhance default setting of property CreationClassName

[Dan Smith]

HE> Not all CIM classes define the property CreationClassName.  This
HE> patch adds a check if CreationClassName is property of the class
HE> and sets it only if there.

This looks like a good idea to me.  I seem to remember SFCB being a
bit different in how it initializes new instance properties.  Did you
test this on SFCB?

HE> +        data = CMGetProperty(inst, "CreationClassName", &s);
HE> +        if (s.rc ==CMPI_RC_OK)
                      ^^^^^^^^^^^^

You need some whitespace there.

Other than that, I think it's good.

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080221/debf7f54/attachment.sig>