[Libvirt-cim] [PATCH] Enhance default setting of property CreationClassName

Heidi Eckhart heidieck at linux.vnet.ibm.com
Fri Feb 22 09:51:06 UTC 2008


Dan Smith wrote:
> HE> Not all CIM classes define the property CreationClassName.  This
> HE> patch adds a check if CreationClassName is property of the class
> HE> and sets it only if there.
>
> This looks like a good idea to me.  I seem to remember SFCB being a
> bit different in how it initializes new instance properties.  Did you
> test this on SFCB?
>   
Its tested on sfcb and Pegasus and works for both.
> HE> +        data = CMGetProperty(inst, "CreationClassName", &s);
> HE> +        if (s.rc ==CMPI_RC_OK)
>                       ^^^^^^^^^^^^
>
> You need some whitespace there.
>   
Hehe ... yes, you are right :) !

-- 
Regards

Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor




More information about the Libvirt-cim mailing list