[Libvirt-cim] [PATCH 1 of 2] Add preliminary XML-parsing support for Xen FV domains

Dan Smith danms at us.ibm.com
Fri Jan 4 15:29:44 UTC 2008


JG> isn't that a spot where we typically use "if (xml == NULL)" for
JG> the sake of clarity?  Using "(!xml)" for the conditional tends to
JG> make me think of xml as an int.

Yes, and it pained me to do it this way.  However, I was keeping with
the rest of Zhengang's style in that file.

I think it would be good to leave it as-is for this patch and then
work up a follow-on that corrects quite a few style issues in that
particular file.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080104/f7a34fe6/attachment.sig>


More information about the Libvirt-cim mailing list