[Libvirt-cim] [PATCH 1 of 2] Add preliminary XML-parsing support for Xen FV domains

Jay Gagnon grendel at linux.vnet.ibm.com
Fri Jan 4 15:44:13 UTC 2008


Dan Smith wrote:
> JG> isn't that a spot where we typically use "if (xml == NULL)" for
> JG> the sake of clarity?  Using "(!xml)" for the conditional tends to
> JG> make me think of xml as an int.
>
> Yes, and it pained me to do it this way.  However, I was keeping with
> the rest of Zhengang's style in that file.
>
> I think it would be good to leave it as-is for this patch and then
> work up a follow-on that corrects quite a few style issues in that
> particular file.
>
>   
Okay, that works for me.


-- 

-Jay




More information about the Libvirt-cim mailing list