[Libvirt-cim] [PATCH 1 of 2] HostSystem: check if input ref is valid

Dan Smith danms at us.ibm.com
Thu Jan 24 16:55:04 UTC 2008


JG> A bit nitpicky here, but I think here name_only is an int that's
JG> being use as a boolean, while getInstance is an actual boolean.
JG> I'm fine with doing things either way, but for the sake of
JG> consistency they should probably be the same.  I'd vote for making
JG> name_only a bool.

Agreed.  She didn't add this, but while it's being modified it would
be nice to get it changed.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080124/f71b1226/attachment.sig>


More information about the Libvirt-cim mailing list