[Libvirt-cim] [PATCH 1 of 2] HostSystem: check if input ref is valid

Jay Gagnon grendel at linux.vnet.ibm.com
Thu Jan 24 19:35:49 UTC 2008


Dan Smith wrote:
> JG> A bit nitpicky here, but I think here name_only is an int that's
> JG> being use as a boolean, while getInstance is an actual boolean.
> JG> I'm fine with doing things either way, but for the sake of
> JG> consistency they should probably be the same.  I'd vote for making
> JG> name_only a bool.
>
> Agreed.  She didn't add this, but while it's being modified it would
> be nice to get it changed.
>
>   
Yea, sorry I forgot to add, "and I won't yell at you for making an
'unnecessary change' since the line is already being modified. :)

-- 

-Jay




More information about the Libvirt-cim mailing list