[Libvirt-cim] [PATCH] RFC: Use of root/interop instead of root/PG_InterOp

Boris Fiuczynski fiuczy at linux.vnet.ibm.com
Tue Nov 26 12:40:30 UTC 2013


On 11/21/2013 09:03 PM, John Ferlan wrote:
...

> diff --git a/schema/FilterList.mof b/schema/FilterList.mof
> index 7339db6..b7d8551 100644
> --- a/schema/FilterList.mof
> +++ b/schema/FilterList.mof
> @@ -10,4 +10,8 @@ class KVM_FilterList : CIM_FilterList
>           MinValue(-1000),
>           MaxValue(1000)]
>           sint16 Priority = 500;
> +
> +        [Description("The network filter UUID value. This value was formerly "
> +                     "stored in the InstanceID field.")]
> +        string InstanceUUID;
>   };
> diff --git a/src/Virt_FilterList.c b/src/Virt_FilterList.c
> index b248004..6a9112e 100644
> --- a/src/Virt_FilterList.c
> +++ b/src/Virt_FilterList.c
> @@ -76,7 +76,7 @@ static CMPIInstance *convert_filter_to_instance(
>           CMSetProperty(inst, "SystemName", sys_name, CMPI_chars);
>           CMSetProperty(inst, "SystemCreationClassName", sys_ccname, CMPI_chars);
>           CMSetProperty(inst, "Name", (CMPIValue *)filter->name, CMPI_chars);
> -        CMSetProperty(inst, "InstanceID", (CMPIValue *)filter->uuid,
> +        CMSetProperty(inst, "InstanceUUID", (CMPIValue *)filter->uuid,
>                           CMPI_chars);
>           CMSetProperty(inst, "Direction", (CMPIValue *)&direction, CMPI_uint16);
>
Hi John,
the changes regarding the FilterList seem strange to me. I would not 
expect any schema changes.
Can you elaborate a bit more why these changes are needed, what made you 
create these changes and how could one recreate a possible error which 
these changes fix?

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the Libvirt-cim mailing list