[Libvirt-cim] [PATCH] RFC: Use of root/interop instead of root/PG_InterOp

[John Ferlan]

On 11/26/2013 07:40 AM, Boris Fiuczynski wrote:
> On 11/21/2013 09:03 PM, John Ferlan wrote:
> ...
>
>> diff --git a/schema/FilterList.mof b/schema/FilterList.mof
>> index 7339db6..b7d8551 100644
>> --- a/schema/FilterList.mof
>> +++ b/schema/FilterList.mof
>> @@ -10,4 +10,8 @@ class KVM_FilterList : CIM_FilterList
>>           MinValue(-1000),
>>           MaxValue(1000)]
>>           sint16 Priority = 500;
>> +
>> +        [Description("The network filter UUID value. This value was
>> formerly "
>> +                     "stored in the InstanceID field.")]
>> +        string InstanceUUID;
>>   };
>> diff --git a/src/Virt_FilterList.c b/src/Virt_FilterList.c
>> index b248004..6a9112e 100644
>> --- a/src/Virt_FilterList.c
>> +++ b/src/Virt_FilterList.c
>> @@ -76,7 +76,7 @@ static CMPIInstance *convert_filter_to_instance(
>>           CMSetProperty(inst, "SystemName", sys_name, CMPI_chars);
>>           CMSetProperty(inst, "SystemCreationClassName", sys_ccname,
>> CMPI_chars);
>>           CMSetProperty(inst, "Name", (CMPIValue *)filter->name,
>> CMPI_chars);
>> -        CMSetProperty(inst, "InstanceID", (CMPIValue *)filter->uuid,
>> +        CMSetProperty(inst, "InstanceUUID", (CMPIValue *)filter->uuid,
>>                           CMPI_chars);
>>           CMSetProperty(inst, "Direction", (CMPIValue *)&direction,
>> CMPI_uint16);
>>
> Hi John,
> the changes regarding the FilterList seem strange to me. I would not
> expect any schema changes.
> Can you elaborate a bit more why these changes are needed, what made you
> create these changes and how could one recreate a possible error which
> these changes fix?
>

BTW: I had a very bad disk crash in my main work environment - I've lost 
everything... It's going to take me a few days to recover... 
Unfortunately for me the backups I thought were occurring - weren't... 
The following is from memory and some notes I have written down...

It seems the newer environment doesn't allow setting the "InstanceID" 
property.  That property is a member of CIM_ManagedElement and the link 
I pointed at in my RFC describes the field. I'm assuming that since 
we've moved to a more common "root/interop" environment and away from 
the (more private) "root/PG_InterOp" environment that somehow there 
needs to be a way to more uniquely identify which provider (namespace) 
is adjusting that value. Reading that webpage description really didn't 
help me figure out what the magic incantation might need to be.  So as 
an alternative I created the new property and thus why I called this an 
RFC because - quite frankly I wasn't sure how to handle it. Note that in 
the new environment "wbemcli ei 
http://root:password@localhost/root/virt:KVM_FilterList" failed to show 
the InstanceID parameter (assuming of course you've applied the rest of 
the changes to use "root/interop")...

Because InstanceID doesn't exist the cimtest for FilterList will fail 
when accessing 'InstanceID' in the python dictionary/list (damn, I wish 
I'd sent that one too - now I have to recreate - sigh)


John