[linux-lvm] '/etc/init.d/lvm' script in debian package

[Gergely Tamas]

Hi!

Some notes to the /etc/init.d/lvm script in the debian packages ...

1] --- it would be better to add '-a ! -d /proc/lvm' as shown bellow,
       becouse in in the newer versions '/proc/lvm' is a directory
       (but what if compiled without /proc/lvm info...)

if [ ! -f /proc/lvm -a ! -d /proc/lvm ]; then
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ was: '[ ! -f /proc/lvm ]; then'

	if [ ! -f /lib/modules/`uname -r`/block/lvm.o -a ! -f /lib/modules/`uname -r`/block/lvm-mod.o ]; then
		exit 0
	fi
fi
---

2] --- I still think that an init.d script should display a usage help as
       default

case "$1" in
	start)
        ^^^^^^ was: 'start|"")'

		echo "Setting up LVM Volume Groups..."
		#/sbin/vgscan
		/sbin/vgchange -a y
		;;

Thanks,
Gergely