[linux-lvm] lvmsar & pvchange minor problems
Heinz J . Mauelshagen
mauelshagen at sistina.com
Wed Sep 25 04:55:47 UTC 2002
Kaoru,
thanks for pointing these out.
I have fixed the "lvmsar -h" bug and removed the wrong array reference
from the debug_leave call in vg_check_active.c.
Both fixes are in CVS now (Branch: LVM_BRANCH_1-0).
Regards,
Heinz -- The LVM Guy --
On Wed, Sep 25, 2002 at 09:13:51AM +0900, kaoru at bsd.tnes.nec.co.jp wrote:
> Hi,
>
> I found minor problems in lvm's commands with kernel 2.4.18 + LVM 1.0.5.
>
> =======
> Lvmsar command does not handle -h option.
>
> # lvmsar -h
> lvmsar -- invalid command line option "h"
>
> # lvmsar --help
> lvmsar -- invalid command line option "h"
>
> # lvmsar -?
>
> Logical Volume Manager 1.0.5
> Heinz Mauelshagen, Sistina Software 15/07/2002 (IOP 10)
>
> lvmsar -- Logical Volume Manager System Activity Data Reporter
>
> Synopsis:
> ---------
>
> lvmsar
> [-d/--debug]
> [-f/--full]
> [-h/--help]
> [-s/--stdin]
> [-v/--verbose]
> LogFilePath
>
>
> =======
> Vg_check_active function printed the following illgal debug messages
> when I executed "pvchange -d".
>
> ....
> <22> vg_check_active_all_vg -- CALLED
> <333> vg_status_get_count -- CALLED
> <333> vg_status_get_count -- LEAVING with ret: 2
> <333> vg_status_get_namelist -- CALLED
> <333> vg_status_get_namelist -- LEAVING with ret: 0
> <22> vg_check_active_all_vg -- LEAVING with ret: 0 ptr: ~H剤D^H^H枝D^H
> <22> pv_check_active -- CALLED
> ....
>
> I made the following patch for this problem, and it seems
> to work. Any comments?
>
> ---8<-----------8<----------8<----------8<----------8<----------
> --- 1.0.5/tools/lib/vg_check_active.c.orig Tue Sep 24 11:12:51 2002
> +++ 1.0.5/tools/lib/vg_check_active.c Tue Sep 24 11:13:21 2002
> @@ -88,6 +88,6 @@
> else ptr = NULL;
>
> debug_leave ( "vg_check_active_all_vg -- LEAVING with ret: %d ptr: %s\n",
> - ret, ptr);
> + ret, (( ptr == NULL ) ? "null" : *ptr));
> return ptr;
> }
> ---8<-----------8<----------8<----------8<----------8<----------
>
> Thanks,
> Kaoru
>
> _______________________________________________
> linux-lvm mailing list
> linux-lvm at sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
*** Software bugs are stupid.
Nevertheless it needs not so stupid people to solve them ***
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Heinz Mauelshagen Sistina Software Inc.
Senior Consultant/Developer Am Sonnenhang 11
56242 Marienrachdorf
Germany
Mauelshagen at Sistina.com +49 2626 141200
FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
More information about the linux-lvm
mailing list