[linux-lvm] clvmd-corosync should check lksb.sb_status instead of return code ?

Chrissie Caulfield ccaulfie at redhat.com
Wed Feb 25 13:30:19 UTC 2009

Xinwei Hu wrote:
> Hi all,
>   In clvmd-corosync, lock_resource calls dlm_ls_lock_wait with flags
> set to LKF_NOQUEUE.
>   When LKF_NOQUEUE is set, the return code of dlm_ls_lock_wait is
> always 0, while the actual errno is in lksb.sb_status.
>   This causes problem when using vgchange -aey or something like.
>   I attached a patch to try to fix this issue.
>   Please help to review. Thanks.


You are correct, the functions do need to check the LKSB. Your patch
isn't quite right I don't think though - the lksb status should be
returned in errno as shown below:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: clvmd-corosync2.diff
Type: text/x-patch
Size: 968 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-lvm/attachments/20090225/0a81ab62/attachment.bin>

More information about the linux-lvm mailing list