[linux-lvm] clvmd-corosync should check lksb.sb_status instead of return code ?

Xinwei Hu hxinwei at gmail.com
Wed Feb 25 13:34:40 UTC 2009

Hi Chrissie,

  You are right. It should be returned in errno. Also, it seems errno
should positive as lksb.sb_status too.

  I modified the patch a little bit further.

  Any comments ?

2009/2/25 Chrissie Caulfield <ccaulfie at redhat.com>:
> Xinwei Hu wrote:
>> Hi all,
>>   In clvmd-corosync, lock_resource calls dlm_ls_lock_wait with flags
>> set to LKF_NOQUEUE.
>>   When LKF_NOQUEUE is set, the return code of dlm_ls_lock_wait is
>> always 0, while the actual errno is in lksb.sb_status.
>>   This causes problem when using vgchange -aey or something like.
>>   I attached a patch to try to fix this issue.
>>   Please help to review. Thanks.
> Hi
> You are correct, the functions do need to check the LKSB. Your patch
> isn't quite right I don't think though - the lksb status should be
> returned in errno as shown below:
> --
> Chrissie
> _______________________________________________
> linux-lvm mailing list
> linux-lvm at redhat.com
> https://www.redhat.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clvmd-corosync2.diff
Type: text/x-patch
Size: 966 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-lvm/attachments/20090225/86473f98/attachment.bin>

More information about the linux-lvm mailing list