[linux-lvm] FW: [lvm-devel] [PATCH 1/3] use display_size function instead of hardcoding

Alasdair G Kergon agk at redhat.com
Mon Sep 28 12:11:53 UTC 2009


----- Forwarded message from Daniel Mierswa <impulze at impulze.org> -----

We should use display_size everywhere for consistency reasons. Other
commands and places that print the stripe/PE size already do that.
This might break scripts that rely on the stripe/PE size being printed
in KByte in those circumstances.

----- End forwarded message -----

Specifically this changes the following:

  1) The 'PE Size' line of 'pvdisplay -v'.

  2) The 'Stripe size' line of a striped segment in 'lvdisplay --maps'.

With this patch, these lines will now be controlled by --units and --nosuffix
etc.

If you have scripts that parse this output, now would be a good time to
switch to the column-based output by adding --columns or using 'pvs -o
vg_extent_size' or 'lvs -o stripesize'.

-    Stripe size		64 KB
+    Stripe size		64.00 KB
 
-  PE Size (KByte)       4096
+  PE Size               4.00 MB
 
Alasdair




More information about the linux-lvm mailing list