[lvm-devel] Posting a patch

[Bryn M. Reeves]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerrard Geldenhuis wrote:
> I have written a small patch for the man page lvm.8 that I want to
> submit. However I am unsure whether I should be creating a diff with cvs
> or diff and then if I use either what type of diff needs to be
> submitted.

Hi Gerrard,

You can generate the patch either way - whichever you prefer. Either one
should be generated in unified diff format (-u). When I am taking
patches from CVS I normally do:

cd ~/cvs/LVM2
cvs diff -up 2>/dev/null > the.patch

The "-p" causes the diff to include the declaration for the function
being changed - very handy for patches to .c files but probably not
necessary for a man page patch.

Otherwise, I'd do something like:

cd LVM2/
diff -Nurp man/lvm.8.orig man/lvm.8 > the.patch

Again, the -Nrp options probably aren't needed for a man page patch but
that's what I use for generating most of my patches.

Regards,
Bryn.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFH4mpo6YSQoMYUY94RAibJAKDJq84LVcWj6EzgC8/PkzZAET7tJACfSBlD
tajy6BSeCkM1F+sM2LSsNyM=
=6w4B
-----END PGP SIGNATURE-----