[PATCH] Re: [lvm-devel] lvconvert error when converting a linear to a mirror

[Petr Rockai]

Hi,

"Jun'ichi Nomura" <j-nomura at ce.jp.nec.com> writes:
> And a comment for this comment in the code:
>
>>          * FIXME This check used to precede mirror->mirror conversion
>> 	 * but didn't affect mirror->linear or linear->mirror. I do
>> 	 * not understand what is its intention, in fact.
>
> if the check wasn't done for mirror-to-linear conversion, that's a bug.
> It seems the bug has been there since the initial version of lvconvert.c. :)

I am the author of that FIXME comment there. It seems, that Dave's proposal of
adding a lv->status & MIRRORED check is the right solution here. Thanks both
for noticing and explaining the issue, at the time I was implementing lvconvert
--repair, it was not clear to me.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvconvert-multiseg-mirror-check.diff
Type: text/x-diff
Size: 797 bytes
Desc: lvconvert-multiseg-mirror-check.diff
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20090519/a028f767/attachment.bin>
-------------- next part --------------

Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation