[PATCH] Re: [lvm-devel] lvconvert error when converting a linear to a mirror

[Milan Broz]

Petr Rockai wrote:
> Hi,
> 
> "Jun'ichi Nomura" <j-nomura at ce.jp.nec.com> writes:
>> And a comment for this comment in the code:
>>
>>>          * FIXME This check used to precede mirror->mirror conversion
>>> 	 * but didn't affect mirror->linear or linear->mirror. I do
>>> 	 * not understand what is its intention, in fact.
>> if the check wasn't done for mirror-to-linear conversion, that's a bug.
>> It seems the bug has been there since the initial version of lvconvert.c. :)
> 
> I am the author of that FIXME comment there. It seems, that Dave's proposal of
> adding a lv->status & MIRRORED check is the right solution here. Thanks both
> for noticing and explaining the issue, at the time I was implementing lvconvert
> --repair, it was not clear to me.

Ack,

(I think we already discussed several times why this check is here, 
so simple disabling multisegment mirrors is ok here.

Maybe error message could explain it to user more precisely too?)


Milan